pitfriedrich/chart-app
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix: i18n for TimePicker #9

Merged
pitfriedrich merged 1 commits from ai/issue-8-timepicker-i18n into main 2026-07-25 20:02:11 +00:00
Conversation 0 Commits 1 Files Changed 4
+18
claude-bot commented 2026-07-25 20:00:37 +00:00
Collaborator
Copy Link
Copy Source

Closes #8

Mirrors the DatePicker i18n setup in FormView for TimePicker:

  • setLocale(Locale.GERMANY) on the uhrzeit TimePicker
  • TimePicker.TimePickerI18n wired with translated error messages (bad input, required, min, max) via existing vaadin-i18n bundles (DE/EN/ES)

Note: TimePickerI18n only exposes error-message setters (no month/weekday names like DatePickerI18n), so full parity means locale + translated validation messages.

Closes #8 Mirrors the DatePicker i18n setup in `FormView` for TimePicker: - `setLocale(Locale.GERMANY)` on the `uhrzeit` TimePicker - `TimePicker.TimePickerI18n` wired with translated error messages (bad input, required, min, max) via existing `vaadin-i18n` bundles (DE/EN/ES) Note: `TimePickerI18n` only exposes error-message setters (no month/weekday names like `DatePickerI18n`), so full parity means locale + translated validation messages.
claude-bot added 1 commit 2026-07-25 20:00:38 +00:00
fix: add i18n for TimePicker matching DatePicker (#8)
CI / build-and-test (pull_request) Successful in 1m9s
Details
e3342d0f53 
Set German locale on TimePicker in FormView and wire TimePickerI18n
error messages (bad input, required, min, max) through the existing
vaadin-i18n translation bundles, mirroring the DatePicker.DatePickerI18n
setup already present in FormView.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PYAcKoXKPN3rJ7nBroKZkc
pitfriedrich merged commit 12761d53ca into main 2026-07-25 20:02:11 +00:00
pitfriedrich deleted branch ai/issue-8-timepicker-i18n 2026-07-25 20:02:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ai-blocked
AI Autofix is blocked - issue needs human
 ai-ready
May be solved by the Autofix loop
 ai-review
Autofix is done, merge ready
 ai-wip
AI Autofix is work-in-progress
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude-bot pitfriedrich
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pitfriedrich/chart-app#9
Delete Branch "ai/issue-8-timepicker-i18n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?